ethtool: Add ifalias label option#3632
Open
jtrunce wants to merge 2 commits into
Open
Conversation
Signed-off-by: Justinas Trunce <justinas@trunce.net> Signed-off-by: jtrunce <justinas.trunce@hostinger.com>
jtrunce
force-pushed
the
ethtool_add_ifalias_label
branch
from
49ec0b6 to
9c31d8d
Compare
Author
|
Hey @SuperQ could you take a look at this when you have some time? |
SuperQ
changed the title
Member
|
Looks like the test fixtures need updating. |
SuperQ
requested changes
Jul 10, 2026
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
Needs updates to the end-to-end tests.
It would also be good to update /end-to-end-test.sh with this feature enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the option to add an
ifaliaslabel to Ethtool collector metrics. It would be a very convenient addition as netdev collector already supports the option