fix: make e2e helper TLS safe#3628
Open
ANISHSAJIKUMAR wants to merge 4 commits into
Open
Conversation
|
What exactly does this accomplish, https is not used in this test |
SuperQ
requested changes
Jul 10, 2026
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
This is the opposite of making things "TLS Safe".
This needs a DCO sign-off. You can use git commit -s --amend to add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teach the end-to-end test helper to use TLS-safe flags for curl and wget so the healthcheck flow keeps working when node_exporter is exposed over HTTPS. This removes a small but real test-time failure mode without changing the exporter itself.