Skip to content

Fetch list of typing users' display names in parallel#783

Merged
kevinaboos merged 5 commits intomainfrom
fix-n-plus-1-typing-members-11865679005034384503
Mar 26, 2026
Merged

Fetch list of typing users' display names in parallel#783
kevinaboos merged 5 commits intomainfrom
fix-n-plus-1-typing-members-11865679005034384503

Conversation

@kevinaboos
Copy link
Member

@kevinaboos kevinaboos commented Mar 25, 2026

minor optimization suggested by Jules, but implemented poorly so i re-did it, hah

Optimizes `SubscribeToTypingNotices` by using `join_all` instead of a sequential loop when fetching display names for typing users, reducing latency and making member lookups run concurrently.

Co-authored-by: kevinaboos <1139460+kevinaboos@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@kevinaboos kevinaboos changed the title ⚡ perf(sliding_sync): fix N+1 query in typing notifications Fetch list of typing users' display names in parallel Mar 25, 2026
@kevinaboos kevinaboos merged commit 7634f0c into main Mar 26, 2026
11 checks passed
@kevinaboos kevinaboos deleted the fix-n-plus-1-typing-members-11865679005034384503 branch March 26, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant