fix: render promo banner as complementary landmark, not contentinfo - #1566
Merged
Conversation
coseeian
added
the
Accessibility: Best Practice
Member
|
Nice, this makes a lot of sense |
ksen0
approved these changes
Aug 11, 2026
Collaborator
Author
|
Hi @ksen0, Quick nudge on this PR. No rush, but whenever you have a free moment to merge it, that would be awesome - I’m getting ready to open the next PR about playwright scan on CI building on top of this work. Thanks again for the review! |
Member
|
Thanks for the bump, will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a duplicate
contentinfolandmark issue introduced in #929.Because both the promo banner and the main site footer were rendered as root-level
<footer>elements, twocontentinfolandmarks were generated in the accessibility tree. This was flagged during Playwright axe-core scan (axe rule details). While HTML permits multiple footers, ARIA best practices recommend maintaining a singlecontentinfolandmark per document so screen reader users aren't confused with multiple primary footers (see MDN docs).Since the banner is a dismissible promo rather than main footer content, I think it should be reasonable to change the landmark to
complementary(using an HTML<aside>), which still keeps it easily accessible without conflicting with the main footer.Visual styling remains unchanged. Feedback on the role or label choice is very welcome. Thanks!