Skip to content

Fix Avatar sizing in Button leading visual - #8631

Open
Akibss21co036 wants to merge 1 commit into
primer:mainfrom
Akibss21co036:fix-avatar-button-sizing
Open

Akibss21co036 wants to merge 1 commit into
primer:mainfrom
Akibss21co036:fix-avatar-button-sizing

Conversation

@Akibss21co036

Copy link
Copy Markdown

Summary

  • Prevent Avatar elements from shrinking by adding matching min-width constraints for regular and responsive sizes.
  • Add regression tests for Avatar sizing inside a Button's leadingVisual slot when a global img { max-width: 100% } rule is applied.
  • Add a Storybook example demonstrating an Avatar used as a Button leading visual.

Testing

  • Button tests: 60 passed.
  • Avatar tests: 14 passed.
  • Type-checking, Stylelint, Prettier, and git diff --check passed.

Rollout strategy

  • Not sure (open-source contributor)

Changelog

Changed

  • Prevent Avatar sizing from collapsing in constrained layouts.

@Akibss21co036
Akibss21co036 requested a review from a team as a code owner October 28, 2026 17:13
@Akibss21co036
Akibss21co036 requested review from jonrohan and a balanced review from Copilot October 28, 2026 17:13
@changeset-bot

changeset-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a104f0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

This branch was successfully deployed

1 active deployment
github-pages — a104f0df Deployed Oct 28, 2026 by Akibss21co036 via deploy-preview #30228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants