[4기 - 한승원] 1~2주차 과제 : 계산기 구현 미션 제출합니다(테스트코드) #193
Open
SW-H wants to merge 47 commits intoprgrms-be-devcourse:seungwon-testfrom
Open
[4기 - 한승원] 1~2주차 과제 : 계산기 구현 미션 제출합니다(테스트코드) #193SW-H wants to merge 47 commits intoprgrms-be-devcourse:seungwon-testfrom
SW-H wants to merge 47 commits intoprgrms-be-devcourse:seungwon-testfrom
Conversation
- 입력 : 사용자 메뉴 선택, 수식 - 출력 : 계산 결과
8 tasks
ICCHOI
reviewed
Jun 19, 2023
ICCHOI
left a comment
ICCHOI
left a comment
There was a problem hiding this comment.
안녕하세요 승원님!
테스트 코드 잘 짜주신 것 같아요.
그런데 여러 클래스의 테스트 코드가 한 곳에 모여있어서, 클래스 별 테스트 파일을 만든 후 단위 테스트를 작성한 후, (지금과 같은 스타일인) 통합 테스트를 작성해보시는 건 어떨까요?
추가적으로 given - when -then과 같은 패턴을 사용해서 작성하면 좀 더 가독성이 좋을 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
사칙연산에 대한 테스트 코드를 작성했습니다.
✅ PR 포인트 & 궁금한 점
계산기 기능(사칙연산)에 대한 코드도 포함되었는데
src/test/java/CalculatorTest.java파일 중심으로 확인부탁드립니다🤩