Open
Conversation
e1himself
approved these changes
Dec 27, 2023
Comment on lines
+6
to
+7
| expect(convertSizesToWidths('test string 123')).toEqual([]); | ||
| expect(convertSizesToWidths('test, 123')).toEqual([]); |
Contributor
There was a problem hiding this comment.
Should it maybe throw instead? Just to not cover possible human mistakes?
Contributor
Author
There was a problem hiding this comment.
Yeah, I agree it makes sense to throw 👍🏻
| image, | ||
| style, | ||
| title, | ||
| sizes = '(max-width: 992px) 800px, (max-width: 576px) 400px, 1200px', |
Contributor
There was a problem hiding this comment.
Is the order correct here? Should it not go from the lowest to the highest max-width values?
Suggested change
| sizes = '(max-width: 992px) 800px, (max-width: 576px) 400px, 1200px', | |
| sizes = '(max-width: 576px) 400px, (max-width: 992px) 800px, 1200px', |
Contributor
Author
There was a problem hiding this comment.
Not sure if the order actually matters here, couldn't find anything pointing to that 🤔
Contributor
There was a problem hiding this comment.
I've tested this in JSFiddle, and it seems they have to follow the lowest-to-highest order. Otherwise the smaller breakpoint following a larger one will be ignored.
Compare these two:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
widthandheightfor images (prevent CLS issues)sizesstring, generate thesrcsetbased on thesizesproperty