Fix issues with deepinstall.js on windows#799
Open
rtm516 wants to merge 3 commits intopostmanlabs:developfrom
Open
Fix issues with deepinstall.js on windows#799rtm516 wants to merge 3 commits intopostmanlabs:developfrom
rtm516 wants to merge 3 commits intopostmanlabs:developfrom
Conversation
This fixes an issue with installing on windows due to touch not being available
shamasis
reviewed
Nov 12, 2025
| command = 'yarn install --production --frozen-lockfile'; | ||
| } | ||
| else { | ||
| command = 'touch yarn.lock && yarn workspaces focus --all --production' |
Member
There was a problem hiding this comment.
@VShingala ... why would we even need to touch yarn.lock in the first place?
AI says:
touch yarn.lock updates the file’s modification timestamp without changing its contents.
Old versions of Yarn (especially v2+ “Berry”) used mtime checks to decide whether to regenerate the .pnp.cjs file or re-link workspace dependencies.
If the yarn.lock looked older than .pnp.cjs or the cache, Yarn might skip re-processing it.
So, “touching” it ensures Yarn thinks “lockfile just changed — better re-resolve workspace deps.”
Don't think this is still relevant.
Fixes an issue where the next is called 2x due to return not being handled as expected
Author
|
Added another fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with installing on windows due to
touchnot being available.It also resolves a bug where the for loop can't return as expected causing next to be called 2x.
EG: