Feature: reusing matching and duplicated positional parameters in prepared statements - #1191
Draft
TeeAaTeeUu wants to merge 1 commit into
Draft
Conversation
Deduplicate positional parameters, to simplify prepared statements positional parameters in case there are duplicates.
For example `${organization_id}` a few times in a more complex nested statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming there usually are only handful of unique positional parameters used per prepared statement, we can rather efficiently find matching ones. This practically moves some of the processing away from Postgres server, to be simplified already on javascript-client side.
Escaping and encoding parameters still happens fully on the Postgres server side.
Input
Output
I'm not fully convinced myself of this actually being something we would want, but leaving it here in case this would be deemed useful by others.