Conversation
Bumping the pin is a documented manual procedure in every consumer, touching ~5 sites per repo: the Cargo.toml rev, the JS facade's github: spec, and every actions/*@<rev> literal in workflows. `pins bump <rev>` rewrites the declared pins in place — anchored the same way the check half reads them (crate/package names; the repository path for workflow refs, which a rename must edit anyway) — and prints the lockfile-regeneration follow-ups it deliberately does not run. Lockfiles stay owned by cargo/npm/pnpm; `pins` remains the verifier. The 40-hex replacement reuses collect_revs' boundary rule, so integrity strings and the consumers' grep-guard regex text survive. Fixes #60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60 (umbrella #14).
component-test pins bump <rev> [--cargo-toml …]… [--package-json …]… [--workflow …]…rewrites the declared pins in place:Cargo.toml:rev = "<40-hex>"on git-dependency lines naming acomponent-test-*crate (name-anchored, single-line dep form — what every consumer uses); reports the crate names for thecargo update -pfollow-up.package.json: bounded 40-hex runs on lines naming@polymorph/component-test-js(same boundary rule as the check half — integrity strings survive).@<40-hex>on lines containingpolymorph-test/actions/(auses:ref embeds the repo path by construction, so a rename edits those lines regardless); the consumers' grep-guard regex text is untouched (asserted by test).Deliberately not done: lockfile edits. The command prints the follow-ups (
cargo update -p …,npm install/pnpm install, then thepinscheck with--expect <rev>) — regeneration belongs to the package managers, verification to the existing gate. A named file with no matching pin site is an error, not a skip.Verified: unit tests for each rewriter + boundary/no-op/final-newline cases; end-to-end run against a three-file fixture.