aggregate action: self-check the pinned ref against the Cargo.lock - #64
Merged
Conversation
A `uses:` ref cannot interpolate, so three consumers carry the same hand-rolled grep guard asserting the action ref matches the workspace pin. The action now polices its own ref: with the new optional cargo-lock input it derives the pin (crate-name-anchored, the pins rule) and fails on skew when referenced by a 40-hex rev; branch and tag refs skip with a notice, so in-repo dogfooding and exploratory use keep working. No input, no check — backward compatible. Fixes #57.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57 (umbrella #14). webcrypto, websocket, and tls each carry an identical workflow step grepping
actions/aggregate@<40-hex>refs against the Cargo.lock rev, becauseuses:cannot interpolate. The action absorbs the guard:cargo-lockinput: derive the pin (crate-name-anchored oncomponent-test-sdk, same rule aspins), compare to${{ github.action_ref }}.uses: ./actions/aggregatedogfood) skip with a notice.cargo-lock:and delete the grep guard + thect-revoutput plumbing that fed it.