jsr-publish: attach the component assets to the release it creates - #101
Merged
Conversation
A release created with the workflow's own github.token emits no `release: published` event, so release-assets.yml never fires for the releases jsr-publish creates — v0.5.0 and v0.5.1 both needed a manual backfill dispatch. jsr-publish now uploads iroh_endpoint.wasm + SHA256SUMS itself, from the same in-run build it embeds into the published package, so the release asset and the JSR-embedded component are byte-identical by construction. release-assets.yml stays for backfill dispatch and human-published releases; both headers state the split.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the gap observed cutting v0.5.1 (and retroactively v0.5.0):
jsr-publishcreates the release with the workflow's owngithub.token, and token-created releases emit norelease: publishedevent — sorelease-assets.ymlnever fires for them and every publish needed a manual backfill dispatch.jsr-publishnow uploadsiroh_endpoint.wasm+SHA256SUMSitself, right aftergh release create, from the same in-run build it embeds into the published package — the release asset and the JSR-embedded component become byte-identical by construction.release-assets.ymlremains for backfill (workflow_dispatchwith a tag) and for human-published releases (where the event does fire); both workflow headers state the split.Gates: YAML validity checked; the real gate is the next publish dispatch.
Automerge is armed.