wasi-shims: explicit type on the poll export (JSR no-slow-types) - #73
Merged
Conversation
A5's suspending()-wrapped poll export left its public type inferred, which JSR's no-slow-types check rejects — the 0a55393 release run's 'publish unstable prereleases to JSR' step failed on exactly this (core and browser lanes green; the GitHub release cut fine, so only the JSR versions are missing for that commit). deno publish --dry-run passes in wasi-shims/ with the annotation; just test-wasi-shims 46/46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The A5
pollexport (export const poll = suspending(...)) leaves its public type inferred, and JSR's no-slow-types check rejects it — main run 31444185874's publish unstable prereleases to JSR step failed on exactly this symbol (wasi-shims/src/io.ts:143), so0.1.0-pre.g0a55393never published (core + browser lanes green; the GitHub release cut fine).One-line fix: annotate the export.
deno publish --dry-runnow passes inwasi-shims/;just test-wasi-shims46/46.Found while evaluating the A5 kernel for polymorph-iroh's experiments (which are about to delete their own parking machinery in its favor).