version-guard: fetch the last-cut tag with a destination refspec - #234
Merged
Conversation
The v0.5.0 cut's first dispatch failed (closed, as designed) in cut-conventions-goldens: 'git fetch origin refs/tags/v0.4.0' drops the objects into FETCH_HEAD but creates no local ref, so the tag NAME stays unresolvable in the release job's shallow checkout and the goldens diff dies with 'bad revision'. The PR-base fetch this mirrored gets away with a bare source because a raw sha resolves from the object store alone; a tag name needs a ref. Fetch +refs/tags/X:refs/tags/X instead; verified against a real shallow tag-less clone (mock argv keys are re-pinned, but they are what missed this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First v0.5.0 cut dispatch failed closed in
cut-conventions-goldens: the tag fetch lacked a destination refspec, so the shallow release checkout never got a resolvablev0.4.0ref (fatal: bad revision). Objects-into-FETCH_HEAD suffices for the sha-addressed PR-base fetch this mirrored; a tag name needs a local ref.Fix:
git fetch origin +refs/tags/v0.4.0:refs/tags/v0.4.0 --depth=1. Verified against a real--depth=1tag-less clone: old form keeps failing, new form resolves and returns the window's all-A golden statuses (adds are free — the guard then passes). Mock argv keys re-pinned;just test-version-guard50/50.Unblocks the v0.5.0 cut re-dispatch.