docs: adjudicate #165 — enter-sync-call's unbracketed gate is accepted - #174
Merged
Conversation
Named divergence recorded in architecture.md §6: the enter_from/leave_to bracket around FACT sync guest→guest calls stays omitted (host-mediated reentry admitted where the pinned reference traps). Grounds: wasmtime parity, the bracket would reintroduce the await-spanning-lock class removed by #156/#160, and upstream CM PR 705 removes the may_enter flag/trap outright — the divergence is a trailing indicator of that removal and self-resolves at the pin advance (migration map: #173). The code comment at the enter-sync-call gate now cites the adjudication instead of reporting the omission as an open hole. Comment/docs only; gate: just test-runtime (516/0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the #165 adjudication as a named divergence in architecture.md §6 and upgrades the code comment at the
enter-sync-callgate from "reported, not smuggled in" to the adjudicated rationale.Grounds, in the entry: wasmtime parity (
enter_guest_sync_callchecks nothing); taking the bracket would create a guest→guest lock spanning suspension points — the await-spanning-lock class #156/#160 eliminated; and upstream CM#705 removes themay_enterflag/trap outright, so the divergence is a trailing indicator that self-resolves at the submodule pin advance. Migration map: #173. The pinned definitions.py stays the tie-breaker until then.Closes #165. Comment/docs only;
just test-runtimegreen (516/0).