Repository navigation
fix: patch vulnerabilities and update eligible dependencies - #7690
Open
waldekmastykarz wants to merge 19 commits into
Open
waldekmastykarz wants to merge 19 commits into
waldekmastykarz wants to merge 19 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 793232e7-059b-4240-ae2b-03e3eefb236b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 158b7bc2-4690-4b5c-b369-7bf185f5f787
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 36e833d5-8958-455d-8460-05c22e2e3185
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 36e833d5-8958-455d-8460-05c22e2e3185
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Refresh transitive vulnerability fixes while resolving the generated shrinkwrap conflict. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve all changes from pnp#7683 before applying the next eligible update cycle. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Select msal-common 16.15.0, msal-node 7.1.2, and msal-node-extensions 5.5.4 instead of the November 5 releases inherited from the earlier dependency PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Update compatible direct and transitive dependencies published at least seven days ago. Use React.JSX annotations for compatibility with the refreshed React types. Preserve public npm URLs throughout the lockfile. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The core MSAL upgrade lacks real-tenant authentication and cross-platform native-cache validation, while blocked security audits leave a reported critical docs dependency advisory unverified, requiring human assessment of compatibility and security risks.
No open issues 🎉
1 file not reviewed
npm-shrinkwrap.json: Generated file
What changed in this PR
Updates CLI for Microsoft 365 and documentation-site dependencies to address vulnerabilities and refresh eligible packages, while preserving compatibility with updated Zod and React types.
Changes:
- Updates runtime and development dependencies, security overrides, and CLI shrinkwrap selections.
- Handles array-valued JSON Schema types and strengthens the boolean-option assertion.
- Updates five documentation component return annotations to
React.JSX.
Builds, tests, and lint were not independently run. The PR reports successful validation, but final vulnerability counts remain unverified because audit requests were blocked.
| File | Description |
|---|---|
src/utils/zod.ts |
Handles array-valued schema types when parsing command options. |
src/utils/zod.spec.ts |
Asserts that boolean options retain their boolean type. |
package.json |
Updates CLI dependencies and security overrides. |
npm-shrinkwrap.json |
Locks updated CLI dependency selections. |
docs/src/theme/Footer/index.tsx |
Uses the React-scoped JSX return type. |
docs/src/theme/DocBreadcrumbs/index.tsx |
Updates three JSX return annotations. |
docs/src/components/TeamCardOverview.tsx |
Uses the React-scoped JSX return type. |
docs/package.json |
Updates React and Markdown-processing dependencies. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
fix: patch vulnerabilities and update eligible dependencies
Linked Issue
Related: pnp/cli-microsoft365#7683. No separate tracking issue supplied for routine dependency maintenance.
One PR = One Commit
Individual patch commits retain dependency update boundaries for review and rollback. Please squash on merge.
New Command = Five Files
N/A. No commands added. Changes are dependency manifests/lockfiles plus Zod and React type compatibility.
Main Branch Only
Targets pnp/cli-microsoft365:main, not the fork.
Merge Conflicts
Based on upstream main through
81e442db5.Summary
Previous PR
Do not close #7683 automatically. All source changes and most dependency changes are retained, but its shrinkwrap selected three November 5 releases that remain inside cooldown. This PR selects msal-common 16.15.0, msal-node 7.1.2, and msal-node-extensions 5.5.4 instead of 16.16.0, 7.2.0, and 5.6.0. Since not ALL previous lock selections are included, #7683 remains open as requested.
Security status and remaining work
Initial audit: CLI 26 findings (9 high, 16 moderate, 1 low); docs 52 findings (21 critical, 15 high, 12 moderate, 4 low). These are initial package counts, including propagated findings.
Final
npm audit --json --include=dev --include=optional --fetch-retries=0(CLI) andnpm audit --json --include=dev --fetch-retries=0(docs) were blocked by HTTP 429 from the configured feed, even after honoring Retry-After. Direct public npm access failed with ENOTCONN. Current advisory counts are therefore unverified, not zero.Comparing the final locks to the initial advisory snapshot leaves CLI development-tooling glob/minimatch advisories and docs deepmerge, serialize-javascript, tinypool, and uuid advisories. The docs tinypool finding remains critical. Fixes require incompatible transitive upgrades (not forced), or are unavailable (deepmerge). Docusaurus is already latest. This PR does not claim vulnerability-free dependency trees.
Cooldown-deferred updates:
Unrelated major direct upgrades and breaking override bumps are not auto-applied.
Validation
fnm exec --using 24 npm run build— passed.fnm exec --using 24 npm test— passed after each new root patch; final run 17,170 tests, 100% statements/branches/functions/lines.cd docs && fnm exec --using 24 npm run typecheck— passed.cd docs && fnm exec --using 24 npm run build— passed.fnm exec --using 24 npm outdated --json --include=dev --include=optional --fetch-retries=0— completed; only cooldown updates and out-of-range major versions remain.cd docs && fnm exec --using 24 npm outdated --json --include=dev --fetch-retries=0— passed; no outdated direct dependencies.git diff --check upstream/main...HEAD— passed.Real tenant sign-in and cross-platform native token-cache integration were not performed.