Merged
Conversation
…plankton from ECOSMO, and adding models to model library and cmakelists
…rrently not compatible with ersem
…c_radiative_flux. Currently from middle of top layer rather than surface so could be improved
…face rather than average of top layer
… rather than fixed in code
…plankton from ECOSMO, and adding models to model library and cmakelists
…rrently not compatible with ersem
…c_radiative_flux. Currently from middle of top layer rather than surface so could be improved
…face rather than average of top layer
… rather than fixed in code
Closed
Member
|
I am reviewing this now, but one comment on the actual code is whether we want to label the fortran files slightly differently for dvm, i.e. have dvm at the front. This has been done for the module names, but not file names. |
Member
Author
|
Thanks, great suggestion - I've added dvm_ prefix to the relevant files. |
wathen
force-pushed
the
155-release-2026-integration
branch
from
d61a9b4 to
8086da1
Compare
wathen
force-pushed
the
155-release-2026-integration
branch
from
253a5e7 to
e2f4f79
Compare
hpowley
approved these changes
Feb 13, 2026
Member
hpowley
left a comment
hpowley
left a comment
There was a problem hiding this comment.
Tested with gotm with check_conservation_flag=True and at first glance everything looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Work
Fixes
Testing Instructions