Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

Kaya84 patch 1#80

Open
Kaya84 wants to merge 4 commits intopluginsGLPI:masterfrom
Kaya84:Kaya84-patch-1
Open

Kaya84 patch 1#80
Kaya84 wants to merge 4 commits intopluginsGLPI:masterfrom
Kaya84:Kaya84-patch-1

Conversation

@Kaya84
Copy link

@Kaya84 Kaya84 commented Oct 4, 2019

No description provided.

Kaya84 added 4 commits October 4, 2019 09:27
Fix for event logging
Fixed DB calling for table exist
Integration in GLPI 9.4
-----------------------

Beside what they wrote, the way that GLPI handle SIM Card in core modules is really awful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: I do not remember you opened any pull request on GLPI in order to get that fixed. Not sure you even open an issue explainning what could be improved.

Also note there have been development for the 9.5 on that point. Maybe you should this time early test those changes and contribute to get it better if needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My wrong. I pulled for merge but I didn't want this.
My point is that I need the way SIM plugin work, threating the items like a computer or device.
Actually, the SIM mode inside GLPI core (imho) need to be completly rewritten, cause, for example, the search mode (using global search for a number doesn't work).

So, if you want, u can delete my (wrong) pull request and we can work together for change the way GLPI threat SIM Card

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants