Repository navigation
Expand process benchmarks across lifecycle phases and topologies - #302
Open
toby-coleman wants to merge 2 commits into
Open
toby-coleman wants to merge 2 commits into
toby-coleman wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Benchmark comparison for |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing benchmark times one three-component pipeline, skips initialization, runs setup and execution on separate event loops, and never destroys the process. Replace it with 24 cases covering initialization, execution, and the full lifecycle across short/deep chains, narrow/wide fan-out and fan-in, a diamond, and a seeded feedback loop.
Dedicated lightweight components use the production run loop. Every round creates a fresh graph and keeps construction, initialization, execution, and destruction on the same event loop. Counts, checksums, and completion statuses are checked outside the timer, and cleanup also runs when setup/execution fails or benchmarks are disabled.
Document timing boundaries, workload sizes, local in-memory scope, and the existing one-second initialization delay. New case IDs gain a comparison baseline once merged.
Validation:
No production framework code changed.