fix: clustered lighting packed decode stability on Samsung WebGL#8461
Merged
mvaligursky merged 1 commit intomainfrom Feb 14, 2026
Merged
fix: clustered lighting packed decode stability on Samsung WebGL#8461mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Store clustered packed `flags`, `anglesData`, and `colorBFlagsData` as module-scope temporaries instead of struct members to avoid observed precision/corruption issues on some Samsung devices while preserving decode behavior. Fixes #7800. Co-authored-by: Cursor <cursoragent@cursor.com>
willeastcott
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It seems some older Samsung devices loose precision on uints when stored inside a struct (we have similar precision loss issue with shadow matrix on Pixel 5 as well), and so:
ClusterLightDatainto module-scope GLSL variables inclusteredLightPS.Fixes #7800.