Fix flaky tests #5970
Draft
Fix flaky tests #5970
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggest function sleeps for 500ms, so we need sufficient retries to handle both the task execution time and LiveView message processing under low resources. With this I couldn't reproduce anymore in repetead runs. In the other case, funnel saved message may arrive after the test is done and this is when Funnels are listed again.
aerosol
force-pushed
the
fix-flaky-combobox-test
branch
from
b844663 to
bba9740
Compare
zoldar
approved these changes
Dec 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggest function sleeps for 500ms, so we need sufficient retries to handle
both the task execution time and LiveView message processing under low
resources. With this I couldn't reproduce anymore in repetead runs.
In the other case, funnel saved message may arrive after the test is
done and this is when Funnels are listed again.