Skip to content

Forward opaque metrics selectors to the API - #1387

Merged
no-itsbackpack merged 1 commit into
mainfrom
egomez/fix-metrics-query-id-validation
Aug 26, 2026
Merged

Forward opaque metrics selectors to the API#1387
no-itsbackpack merged 1 commit into
mainfrom
egomez/fix-metrics-query-id-validation

Conversation

@no-itsbackpack

Copy link
Copy Markdown
Contributor

Summary

  • accept opaque query pattern IDs in both metrics show and metrics queries
  • stop prevalidating tablet workflow names against only the first workflow page
  • add regression coverage that verifies selectors reach the metrics API unchanged

Test plan

  • go test ./internal/cmd/metrics -count=1

Avoid rejecting valid query and workflow identifiers based on incomplete local assumptions or a single page of workflows.

Co-authored-by: Cursor <cursoragent@cursor.com>
@no-itsbackpack
no-itsbackpack requested a review from a team as a code owner August 26, 2026 01:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved after Cursor Bugbot completed successfully with no findings that need human review; Cursor Security Agent was not running. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: cli-reviewer

@no-itsbackpack
no-itsbackpack merged commit 2e243c4 into main Aug 26, 2026
5 checks passed
@no-itsbackpack
no-itsbackpack deleted the egomez/fix-metrics-query-id-validation branch August 26, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants