Removed IStore.ForkBlockIndexes() and IStore.ForkTxNonces()#4001
Open
greymistcube wants to merge 5 commits intoplanetarium:mainfrom
Open
Removed IStore.ForkBlockIndexes() and IStore.ForkTxNonces()#4001greymistcube wants to merge 5 commits intoplanetarium:mainfrom
IStore.ForkBlockIndexes() and IStore.ForkTxNonces()#4001greymistcube wants to merge 5 commits intoplanetarium:mainfrom
Conversation
greymistcube
force-pushed
the
refactor/remove-fork
branch
from
271e3bb to
13ba5d1
Compare
greymistcube
changed the title
IStore.ForkBlockIndexes() and IStore.ForkTxNonces()
greymistcube
force-pushed
the
refactor/remove-fork
branch
from
0c8963f to
883dc22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing forking methods as they aren't really being used. This allows once created
IStoreto be always pruned oncePruneOutdatedChanes()in #3999 is run. This assumption is critical in removing further code clutter fromIStoreand to implementing better optimizations.