Add adaptive spreading and intensity hysteresis#138
Open
thomas-vilte wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 86.85% 86.86% +0.01%
==========================================
Files 30 31 +1
Lines 6967 7022 +55
==========================================
+ Hits 6051 6100 +49
- Misses 704 707 +3
- Partials 212 215 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RFC 6716 / 8251 conformationStatus: pass The action extracts the RFC 6716 reference implementation, applies the RFC 8251 decoder update patch, and then builds the patched reference tools. Legend: numeric cells are Inputs use the shared RFC 6716 / RFC 8251 bitstream corpus; accepted references follow RFC 8251 Section 11.
Run output |
FrantaBOT
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The encoder was hardcoding spread=NORMAL every frame. This PR makes it actually look at the MDCT spectrum and decide how much spreading the PVQ needs.
Added
spreadingDecision()which computes a peak-to-mean energy ratio per band — tonal signals (one bin dominates) score high, noise-like signals score low. The result feeds a recursive inter-frame average and thenhysteresisDecision()to avoid chattering at threshold crossings. Same idea as libopusspreading_decisionin celt_encoder.c but in float32 with a uniform band weight, since the tonality-based weight is disabled in libopus production anyway.Also added a ±1 dead band for the intensity stereo start band so it can only move one step per frame instead of jumping around.
Reference issue
Fixes #...