*: fix 404 links in the v7.1 documentation - #21941
ti-chi-bot[bot] merged 2 commits into
Conversation
lilin90
added
area/develop
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@coderabbitai[bot]: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
Bot
added
the
size/XS
Update outdated GitHub links in backup/restore and troubleshooting docs to the release-7.1 branch, and replace node-mysql2 English docs with the Chinese documentation pages. Also correct malformed GitHub author links and a mistaken TiCDC author handle in the 6.5.7 and 7.1.3 release notes so the docs render cleanly and point to the right references.
ti-chi-bot
Bot
added
size/S
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates documentation links to release-specific and Chinese mysql2 documentation pages. It also corrects malformed or incorrect GitHub author links in two release-note files. No product behavior or public declarations change. ChangesDocumentation link corrections
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documentation link corrections do not change product behavior and are ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each link with care Comment |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 participant
First-time contributors' checklist
What is changed, added or deleted? (Required)
This PR fixes the 404 links that are still left in the
release-7.1branch, as requested in #17075.#17041 fixed this kind of link in
masterand was cherry-picked only torelease-8.0andrelease-7.5, sorelease-7.1still carries them. I checked every external link that this PR touches: the old URLs return 404 and the new ones return 200.develop/dev-guide-sample-application-aws-lambda.mddevelop/dev-guide-sample-application-nextjs.mdhttps://github.com/sidorares/node-mysql2/tree/master/documentation/enhttps://sidorares.github.io/node-mysql2/docs/documentationtidb-lightning/tidb-lightning-overview.mdtidb-troubleshooting-map.mdhttps://github.com/pingcap/tidb/tree/master/br/pkg/lightninghttps://github.com/pingcap/tidb/tree/release-7.1/br/pkg/lightningbr/br-snapshot-guide.mdfaq/backup-and-restore-faq.mdhttps://github.com/pingcap/tidb/blob/master/br/pkg/restore/systable_restore.go#L31https://github.com/pingcap/tidb/blob/release-7.1/br/pkg/restore/systable_restore.go#L31releases/release-7.1.3.mdreleases/release-6.5.7.mdhttps://github.com/AilinKid}https://github.com/AilinKidreleases/release-6.5.7.mdhttps://github.com/zhangjinpeng1987https://github.com/zhangjinpeng87Three notes on the approach:
pingcap/tidbsource links are pinned torelease-7.1instead ofmaster. br: not support executing backup task and restore task at the same time (#16223) #17041 pointed them tomaster, but inmasterthese paths have moved again (br/pkg/lightningtolightning, andbr/pkg/restore/systable_restore.gotobr/pkg/restore/snap_client). Both paths still exist in therelease-7.1branch ofpingcap/tidb,release-7.5already uses this version-pinned form, and it keeps the linked source consistent with the TiDB version that this documentation describes. Please let me know if you would rather follow themasterform used in br: not support executing backup task and restore task at the same time (#16223) #17041.aliaseschange from br: not support executing backup task and restore task at the same time (#16223) #17041 is not ported. Those aliases cover/tidb/dev/...URLs fordevelop/dev-guide-sample-application-java-jdbc.md. No document in this branch links to the old path, and the corresponding/tidb/v7.1/...URL never existed, so the aliases are not needed here.develop/dev-guide-sample-application-aws-lambda.mdanddevelop/dev-guide-sample-application-nextjs.mdstill link tohttps://ask.pingcap.com/andhttps://support.pingcap.com/, which no longer resolve. They appear in 74 and 79 files across this branch andmasterhas replaced the whole "Need help?" block, so fixing them here would be inconsistent and out of scope. I am happy to file a separate issue or PR for them. Note that this may make theLinks (Fail Fast)job report these two files.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
The fix is version-specific because each branch has to point at its own
pingcap/tidbbranch, so no cherry-pick label is added. A separate PR coversrelease-6.5.What is the related PR or file link(s)?
master)AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit