Update TiProxy to v1.3.3 - #21940
Update TiProxy to v1.3.3#21940djshow832 wants to merge 9 commits into
Conversation
These non-doc files were included in a local commit by mistake and are not part of the TiProxy documentation updates. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough本次变更更新 TiProxy v1.3.3 文档,新增配置项,调整负载均衡说明,更新版本示例,并新增 Connection Lifetime 指标说明。 ChangesTiProxy 文档更新
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The documentation can mislead users about a valid buffer value and about which TiProxy versions support CPU balancing. The impact is limited to configuration and upgrade guidance, but these corrections should be made before release. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: d805ec76-86ef-45b2-bfbb-ce295b145bdf
📒 Files selected for processing (5)
tiproxy/tiproxy-configuration.mdtiproxy/tiproxy-deployment-topology.mdtiproxy/tiproxy-grafana.mdtiproxy/tiproxy-load-balance.mdtiproxy/tiproxy-overview.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · 将 0 加入 conn-buffer-size 的取值范围。 · tiproxy-configuration.md:108-109
tiproxy/tiproxy-configuration.md:108-109
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win将
0加入conn-buffer-size的取值范围。TiProxy 的默认配置将
0定义为使用默认值,同时支持1K到16M。当前范围遗漏了合法值0,会与后文的行为说明冲突。+ 取值范围:`0` 或 `[1024, 16777216]`Source: Path instructions
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: e497a26d-fc80-4b0c-98bc-7e862b01ccd1
📒 Files selected for processing (2)
tiproxy/tiproxy-configuration.mdtiproxy/tiproxy-load-balance.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
|
@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · 明确区分 CPU 负载均衡和新增配置项的版本。 · tiproxy-configuration.md:211-220
tiproxy/tiproxy-configuration.md:211-220
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win明确区分 CPU 负载均衡和新增配置项的版本。
cpu小节标题将 v1.3.3 标记作用于整个配置节。用户可能因此认为 v1.1.0 至 v1.3.2 不支持 CPU 负载均衡,但其他文档明确说明该功能从 v1.1.0 开始支持。请移除小节标题上的版本标记,并保留各配置项的 v1.3.3 标记。#### `cpu` 基于 CPU 的负载均衡配置。TiProxy 从 v1.1.0 开始支持基于 CPU 的负载均衡。本节中的配置项从 v1.3.3 开始引入。仅当 [`policy`](`#policy`) 为 `resource` 或 `location` 时生效。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: cf71b36a-a062-44ed-9d5c-c18fdd41cf76
📒 Files selected for processing (1)
tiproxy/tiproxy-configuration.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
Co-authored-by: Grace Cai <qqzczy@126.com>
What is changed, added, or deleted? (Required)
v1.3.3 was released.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit