Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ticdc/ticdc-ddl.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ summary: 了解 TiCDC 支持同步的 DDL 和一些特殊情况
>
> - 当上游表不存在有效索引,且未配置 `force-replicate=true` 时,该表不会被同步,但是之后在该表上创建有效索引的 DDL (`CREATE INDEX`、`ADD INDEX` 和 `ADD PRIMARY KEY`)会被同步,下游表和上游表结构可能产生不一致从而导致后续数据同步失败。
> - 删除最后一个有效索引的 DDL(`DROP INDEX` 和 `DROP PRIMARY KEY`)不会被同步,并且导致后续数据同步失败。
> - 如果 `ADD COLUMN`,`DROP COLUMN`,`MODIFY COLUMN` 涉及到有效索引的添加删除,其行为表现应该与 `ADD INDEX`,`DROP INDEX`等 DDL 行为表现一致。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

明确列出涉及有效索引变更的 DDL。

DDL 白名单列出了 CREATE INDEXADD INDEXDROP INDEXADD PRIMARY KEYDROP PRIMARY KEY。当前仅列出前两类操作,等 DDL 未明确涵盖主键变更。请替换为:

可直接提交的修改
Suggested change
> - 如果 `ADD COLUMN``DROP COLUMN``MODIFY COLUMN` 涉及到有效索引的添加删除,其行为表现应该与 `ADD INDEX``DROP INDEX`等 DDL 行为表现一致
> - 如果 `ADD COLUMN``DROP COLUMN``MODIFY COLUMN` 涉及添加或删除有效索引,其行为应与 `CREATE INDEX``ADD INDEX``DROP INDEX``ADD PRIMARY KEY``DROP PRIMARY KEY` 等 DDL 的行为一致
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
> - 如果 `ADD COLUMN``DROP COLUMN``MODIFY COLUMN` 涉及到有效索引的添加删除,其行为表现应该与 `ADD INDEX``DROP INDEX`等 DDL 行为表现一致
> - 如果 `ADD COLUMN``DROP COLUMN``MODIFY COLUMN` 涉及添加或删除有效索引,其行为应与 `CREATE INDEX``ADD INDEX``DROP INDEX``ADD PRIMARY KEY``DROP PRIMARY KEY` 等 DDL 的行为一致


| DDL | 存在有效索引 | 无有效索引且 `force-replicate` 为默认值 `false` | 无有效索引且 `force-replicate` 为 `true` |
|---|:---:|:---:| :---: |
Expand All @@ -35,10 +36,10 @@ summary: 了解 TiCDC 支持同步的 DDL 和一些特殊情况
| `DROP PRIMARY KEY` | Y | N | Y |
| `CREATE TABLE` | Y | N | Y |
| `DROP TABLE` | Y | N | Y |
| `ADD COLUMN` | Y | N | Y |
| `ADD COLUMN` | Y | Y:添加有效索引<br>N:没有添加有效索引 | Y |
| `DROP COLUMN` | Y | N | Y |
| `TRUNCATE TABLE` | Y | N | Y |
| `MODIFY COLUMN` | Y | N | Y |
| `MODIFY COLUMN` | Y | Y:添加有效索引<br>N:没有添加有效索引 | Y |
| `RENAME TABLE` | Y | N | Y |
| `ALTER COLUMN DEFAULT VALUE` | Y | N | Y |
| `ALTER TABLE COMMENT` | Y | N | Y |
Expand Down
Loading