[MCP] MCP Server Manager UI (#1309) - #4079
Draft
wwidergoldpimcore wants to merge 11 commits into
Draft
Conversation
UsersRolesDropdown built its badge-label map from the assignable-options list, which filters out the current user (you cannot share with yourself). When the current user was already present in a shared value, their badge rendered blank. Resolve labels from the full user list plus the current user's own name as a fallback; the options list stays filtered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
A Studio settings screen to manage MCP servers: group tools under a URL and control who may use them. Master/detail layout mirroring the agent bundle — a left rail of servers and a right configuration mask (identity, tools, two-level read/write sharing, derived scopes + URL). - Generated RTK Query client from the MCP OpenAPI tag (surgical merge of the MCP paths/schemas into docs.jsonopenapi.json + an openapi-config output entry) -> mcp-servers-api-slice.gen.ts - Master/detail via ConfigLayout; delete confirm; errors routed via trackError - Two-level sharing (read/write grants per user & role) via OperationalGrid, a Global-read toggle, and a live who-can-access summary - Gating: screen reachable by read-consumers (list is row-filtered server-side); New gated on the mcp_servers permission; edit/delete driven by currentUserPermissions.write and the storage writeable flag - Nav entry under Automation & Integration; mcp_servers permission enum case; i18n keys in studio.en.yaml Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reworks the #1309 MCP Server Manager screen to mirror the pimcore-agent-bundle configuration UI: - Master/detail: a server rail with a bottom refresh/new toolbar, and servers opened as editable-card tabs (New opens a create tab) - Editor split into General and Permissions inner tabs; Save fixed in the tabs-level bottom toolbar (via portal slot), Delete moved to a rail context menu - Two-level sharing grid (Read / Can edit per user and role) with a live who-can-access summary; share names resolved from the share collection with a current-user fallback - Success toast on save; read-only handling driven by currentUserPermissions and the storage writeable flag Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The backend's McpServerAccessGrant now carries `name` instead of `id`, so the sharing grid stores and shows the user/role name directly. Removes the id->name resolution (share-collection lookup + current-user fallback) and the grid remount workaround, which also fixes names briefly rendering as `#id` on first load. Regenerated the MCP client from the updated OpenAPI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The backend split server access into three resolved bits: canView, canAccess
and canEdit. Grants now carry canAccess + canEdit as two independent booleans
instead of a single read/write enum, and currentUserPermissions gains canView.
The sharing grid follows the Agent bundle's run/update shape: two real-field
checkbox columns ("Can access" / "Can edit") written straight through onChange,
dropping the synthetic-enum column and its cell-data translation shim. Read-only
mask and delete gating move from currentUserPermissions.write to .canEdit.
Regenerated the MCP client from the updated OpenAPI.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The tab's dirty marker stayed after saving (issue #1451): the dirty baseline and the editor's live fields were seeded from the server at different times, so once the post-save refetch moved the baseline the two never re-equalised for a reordered tools/sharing array. The baseline and fields are now re-seeded together from the same server object whenever it changes, and the dirty effect reacts to data changes only (callbacks held in refs) so the optimistic clear is no longer overwritten while the refetch is in flight — clearing the flag instantly, as the Agent bundle does. The left rail now blanks and rebuilds the whole list on any refetch (matching the Agent tree) instead of patching rows in place, and the tab label is derived from the refreshed server list, so renames surface without the removed renameTab patch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rows Add a name filter (SearchInput, same props as the Agent tree) above the list and tighten the row rhythm — smaller vertical padding, no inter-row gap — so the rail resembles the Agent bundle's config list. The Custom/Preset view switch is intentionally omitted; MCP servers are a flat list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
McpServerAccessGrant gains a canRead boolean (explicit Config Read per grant, with edit implying read); patch the tracked codegen source and regenerate the slice. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… row Split the sharing grid into the three independent capabilities the backend now models (issue #1452): Config Read (canRead), Config Edit (canEdit) and MCP Server Access (canAccess). Config Read is forced on and disabled whenever Edit is set — you cannot edit a config you cannot read — and a new grant starts read-only, with Access and Edit opt-in. The owner's own user row (matched against McpServer.owner) shows Config Read and Config Edit locked-on and disabled — the backend grants the owner those implicitly regardless of the stored flags — leaving only MCP Server Access meaningful to toggle. A normalize pass keeps the displayed rows and any change self-consistent so the disabled boxes always read ticked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The MCP server UI now lives on its own branch on top of the OAuth (1308) branch. Re-merge the MCP schemas (McpServer/McpServerAccessGrant/McpServerUserPermissions/ McpToolItem) and the /mcp/* paths onto the branch's spec so it matches the committed mcp-servers slice; the OAuth consent schemas from the base branch are preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Collaborator
🌐 Translations synced automaticallyThe key changes below were generated for all target languages, passed the Added (54):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the MCP Server Manager UI (#1309) — a Studio settings screen to CRUD MCP servers (name, tools, sharing, enabled) with the three-capability permission model (Config Read / Config Edit / MCP Server Access).
This branch is stacked on top of the OAuth consent branch (
feature/oauth-1308-basic-integration) so the OAuth consent screen can roll out first. It targets that branch (not2026.x) and will be rebased onto it as the base evolves; retarget to2026.xonce #1308 has merged.Scope on top of the base branch is MCP-only:
assets/js/src/core/modules/mcp-servers/**— rail, tabs, editor (general + permissions/sharing), hooksbootstrap.ts),McpServerspermission, share-dropdown label fixmcp-serversslice +mcp-servers.*translationsVerified:
tscclean, eslint clean, full jest suite (624 tests) green.🤖 Generated with Claude Code