Feature/element selector context 431 - #4078
Open
SimonCremer wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new query helper violates enforced formatting and type-safe checking conventions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds field-name filtering to data-object element selectors.
Changes:
- Propagates relation field names into selector configuration.
- Adds a decorator that injects the field-name API filter.
- Ignores local Claude configuration.
File summaries
| File | Description |
|---|---|
element-selector-provider.tsx |
Adds field-name configuration. |
allowed-types.ts |
Propagates combined field names. |
field-name-filter-decorator.ts |
Registers the query decorator. |
with-field-name-filter-query-arg.ts |
Builds the field-name filter. |
data-object-selector-listing.tsx |
Applies the new decorator. |
.gitignore |
Ignores .claude. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SimonCremer
marked this pull request as ready for review
September 3, 2026 11:39
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves pimcore/platform-version#431
Additional info
Add field-name filter to data-object element selector