[Studio UI] Remove extra padding from Saved Searches modal grid - #4069
Open
idaiv wants to merge 2 commits into
Open
[Studio UI] Remove extra padding from Saved Searches modal grid#4069idaiv wants to merge 2 commits into
idaiv wants to merge 2 commits into
Conversation
The Saved Searches tab in the search modal had double margins on the
grid (Content margin + Box margin) and a Box-wrapped TopBar with
custom padding, making it misaligned with the other tabs (Documents,
Assets, Data Objects).
- Removed Content margin={{ x: 'extra-small' }} and the inner Box
wrapper around the Grid
- Replaced the Box-wrapped SearchInput TopBar with a Toolbar matching
the other tabs (secondary theme, padding left/right none)
- Removed unused Box import and styles
Relates to pimcore/product-management#1459
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused presentation change follows existing search-tab patterns without introducing functional or compatibility risk.
Pull request overview
Verdict: LGTM. This locally fixes the reported double margin at its owning component without API or shared-behavior changes.
Changes:
- Replaces the padded
Boxtop bar with the establishedToolbarpattern. - Removes nested grid margins and unused imports/styles usage.
- No regression test added; manual visual verification remains.
File summaries
| File | Description |
|---|---|
saved-searches-tab.tsx |
Aligns the Saved Searches grid and search bar with sibling tabs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: https://github.com/pimcore/product-management/issues/1459
Summary
The Saved Searches tab in the search modal had extra paddings making the grid misaligned with the other tabs (Documents, Assets, Data Objects).
Contentmargin + innerBoxmargin)Box-wrapped SearchInput TopBar with aToolbar(secondary theme,padding: { left: 'none', right: 'none' }), matching the other tabsBoximport anduseStylesRelates to https://github.com/pimcore/product-management/issues/1459
Test plan
🤖 Generated with Claude Code