[Studio UI] Add global focus-visible indicator for keyboard users - #4067
Merged
Conversation
Consistent 2px outline on :focus-visible for all interactive elements. Hidden on mouse clicks via :focus:not(:focus-visible). Uses Ant Design's --ant-color-primary-border CSS variable for theme consistency. Fixes WCAG 2.4.7 (Focus Visible) globally across the app. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
idaiv
added
the
Skip Milestone Check
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Existing component styles override the indicator, and its color does not follow the active theme.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds global keyboard-focus styling to improve accessibility.
Changes:
- Adds a 2px
:focus-visibleoutline. - Suppresses outlines for pointer focus.
File summaries
| File | Description |
|---|---|
assets/css/globals.css |
Defines global focus indicator rules. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * Shows a consistent 2px outline on keyboard focus, hidden on mouse clicks. | ||
| * Uses the Ant Design primary border color variable for theme consistency. | ||
| */ | ||
| :focus-visible { |
| * Uses the Ant Design primary border color variable for theme consistency. | ||
| */ | ||
| :focus-visible { | ||
| outline: 2px solid var(--ant-color-primary-border, #91caff); |
The previous --ant-color-primary-border fallback (#91caff) was the default Ant blue, not the Pimcore purple. Use --ant-color-primary (theme-derived #722ed1) with --pimcore-brand-color as secondary fallback and #722ed1 as hardcoded last resort. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Use --pimcore-brand-color with #722ed1 fallback (Ant CSS variable mode is not enabled, so --ant-color-primary is unavailable) - Fix icon-button.styles.ts: was outline:none !important on :focus-visible, now shows the purple focus ring matching the global style Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
idaiv
removed
the
Skip Milestone Check
|
vin0401
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:focus-visiblestyle inglobals.css— 2px outline on keyboard focus:focus:not(:focus-visible)hides outline on mouse clicks--ant-color-primary-borderCSS variable for theme consistencyTest plan
Relates to https://github.com/pimcore/product-management/issues/372
🤖 Generated with Claude Code