Skip to content

Fix video fields inside field collections #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pverdu-emico wants to merge 1 commit into
base: 2026.x
Choose a base branch
from
Open

Fix video fields inside field collections #4064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 17 additions & 28 deletions ...odules/element/dynamic-types/definitions/objects/data-related/components/video/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @license Pimcore Open Core License (POCL)
*/

import React, { type ReactElement, useState } from 'react'
import React, { type ReactElement } from 'react'
import { IconButton } from '@Pimcore/components/icon-button/icon-button'
import {
type VideoType,
Expand All @@ -17,8 +17,8 @@ import {
import { useTranslation } from 'react-i18next'
import { ButtonGroup } from '@Pimcore/components/button-group/button-group'
import { Tooltip } from '@Pimcore/components/tooltip/tooltip'
import { VideoModal } from '@Pimcore/modules/element/components/video-modal/video-modal'
import { isEmpty } from 'lodash'
import { useVideoModal } from '@Pimcore/modules/element/components/video-modal/hooks/use-video-modal'
import { isEmpty, isNull } from 'lodash'

interface VideoFooterProps {
emptyValue?: () => void
Expand All @@ -31,19 +31,18 @@ interface VideoFooterProps {

export const VideoFooter = (props: VideoFooterProps): React.JSX.Element => {
const { t } = useTranslation()
const [isModalVisible, setIsModalVisible] = useState(false)
const { openModal } = useVideoModal({
allowedVideoTypes: props.allowedVideoTypes,
disabled: props.disabled,
onChange: (value: VideoValue | null): void => {
if (!isNull(value)) {
props.onSave?.(value)
}
}
})

const showModal = (): void => {
setIsModalVisible(true)
}

const handleModalOk = (value: VideoValue): void => {
props.onSave?.(value)
setIsModalVisible(false)
}

const handleModalCancel = (): void => {
setIsModalVisible(false)
openModal(props.value)
}

const buttons: ReactElement[] = []
Expand Down Expand Up @@ -104,19 +103,9 @@ export const VideoFooter = (props: VideoFooterProps): React.JSX.Element => {
}

return (
<>
<ButtonGroup
items={ buttons }
noSpacing
/>
<VideoModal
allowedVideoTypes={ props.allowedVideoTypes }
disabled={ props.disabled }
onCancel={ handleModalCancel }
onOk={ handleModalOk }
open={ isModalVisible }
value={ props.value }
/>
</>
<ButtonGroup
items={ buttons }
noSpacing
/>
)
}
Loading