Add tooltip to running jobs sidebar button - #4053
Open
sholzer wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. The PR adds a localized tooltip to the running-jobs sidebar button.
Changes:
- Adds the tooltip to
NotificationButton. - Adds translations for all seven supported locales.
Assessment:
- Root cause addressed at the owning component; its only registration is covered.
- No API or backward-compatibility impact.
- No automated regression test was added.
- Accessibility remains unresolved: the icon-only button lacks an accessible name.
- No documentation or changelog update is necessary.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
notification-button.tsx |
Adds the localized right-side tooltip. |
studio.en.yaml |
Adds English text. |
studio.de.yaml |
Adds German text. |
studio.es.yaml |
Adds Spanish text. |
studio.fr.yaml |
Adds French text. |
studio.it.yaml |
Adds Italian text. |
studio.no.yaml |
Adds Norwegian text. |
studio.sv.yaml |
Adds Swedish text. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| description: <JobList /> | ||
| }) | ||
| } } | ||
| tooltip={ { title: t('jobs.notification.tooltip'), placement: 'right' } } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jobs.notification.tooltip, translated into de/fr/it/es/sv/noTest plan
🤖 Generated with Claude Code