[Studio UI] Add Home/End key navigation to tree - #4051
Closed
idaiv wants to merge 4 commits into
Closed
Conversation
Home jumps to the first visible node, End to the last. Consolidated the four navigation functions (next/prev/first/last) into a single gotoNode helper to stay within the file line limit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
idaiv
added
the
Skip Milestone Check
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. The PR directly adds the missing Home/End navigation at the owning tree-node component.
Changes:
- Routes arrow and boundary navigation through
gotoNode. - Adds Home/End focus behavior for visible nodes.
- No public API or compatibility impact.
Assessment:
- Root cause: Addressed directly at
tree-node.tsx:169-202. - Call sites/boundary: All keyboard branches use the local helper.
- Tests: Missing automated keyboard regression coverage.
- Docs: No public API documentation change needed.
- Remaining risk: Home/End and refactored arrow behavior remain manually verified only.
- Findings: Missing tests and nonconforming array emptiness check at
tree-node.tsx:197.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+177
to
+181
| if (event.key === 'Home') { | ||
| gotoNode(event, 'first') | ||
| } | ||
|
|
||
| if (event.key === 'End') { |
| if (index > 0) { | ||
| nodesRefs!.current[nodeOrder!()[index - 1]].el.focus() | ||
| const order = nodeOrder!() | ||
| if (order.length === 0) return |
Follow project convention: use lodash isEmpty() instead of direct array length check in gotoNode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
8 tasks
Contributor
Author
|
Superseded by #4048 which includes Home/End keys along with the full tree navigation rewrite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gotoNodehelperTest plan
🤖 Generated with Claude Code