[Studio UI] Add Escape key to cancel grid cell edit mode - #4049
Open
idaiv wants to merge 4 commits into
Open
Conversation
Users could enter edit mode with Enter but had no keyboard way to cancel — they had to click away. Pressing Escape now exits edit mode and returns focus to the cell. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
idaiv
added
the
Skip Milestone Check
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. Adds shared Escape handling for grid cell edit mode, but restoring focus immediately can trigger editor blur handlers and commit the cancelled value.
Changes:
- Exits edit mode when Escape is pressed.
- Stops Escape propagation and restores cell focus.
Assessment:
- The owning
DefaultCellboundary covers all cell renderers without API changes. - The immediate focus at line 181 triggers save-on-blur editors; the existing effect at lines 78–82 should restore focus after unmount.
- No regression test was added to verify cancellation without saving. No documentation change appears necessary.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+178
to
+182
| if (event.key === 'Escape' && isInEditMode) { | ||
| event.stopPropagation() | ||
| setIsInEditMode(false) | ||
| element.current?.focus() | ||
| } |
Focusing the cell synchronously while the editor is still mounted triggers onBlur, causing the editor to save the draft value. Use requestAnimationFrame so the editor unmounts before focus moves. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
idaiv
removed
the
Skip Milestone Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
Relates to https://github.com/pimcore/product-management/issues/372