[Studio UI] Fix sort button triggering on any keypress - #4047
Open
idaiv wants to merge 4 commits into
Open
Conversation
The onKeyUp handler called onClick on every key, causing unintended sort direction changes during normal keyboard interaction. Now only Enter and Space trigger the sort toggle. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
idaiv
added
the
Skip Milestone Check
Contributor
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. The change correctly limits sort activation to Enter and Space at the owning component.
Changes:
- Filters keyboard-triggered sorting by key.
- Covers all
SortButtonconsumers without API changes. - Missing regression tests; Space can still scroll because cancellation occurs on
keyup. - No documentation changes are necessary.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+40
to
+45
| onKeyUp={ (event) => { | ||
| if (event.key === 'Enter' || event.key === ' ') { | ||
| event.preventDefault() | ||
| onClick() | ||
| } | ||
| } } |
Comment on lines
+40
to
+45
| onKeyUp={ (event) => { | ||
| if (event.key === 'Enter' || event.key === ' ') { | ||
| event.preventDefault() | ||
| onClick() | ||
| } | ||
| } } |
preventDefault on keyup is too late to cancel Space's default scroll. Switch to onKeyDown so Space activation doesn't also scroll the page. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
idaiv
removed
the
Skip Milestone Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onKeyUpfired the sort toggle on every keypress, causing unintended sort changesTest plan
🤖 Generated with Claude Code
Relates to https://github.com/pimcore/product-management/issues/372