Feature/element selector context 431 - #2024
Open
SimonCremer wants to merge 2 commits into
Open
Conversation
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused enum addition is correctly placed and introduces no identified regression.
Pull request overview
Adds the SYSTEM_FIELD_NAME grid column type required by platform-version#431.
Changes:
- Adds the public enum value
system.fieldName. - Change is additive and backward compatible.
- No internal call sites require updates; external issue details could not be verified.
File summaries
| File | Description |
|---|---|
src/Grid/Column/ColumnType.php |
Defines the new system field-name column type. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves pimcore/platform-version#431
Additional info
Add SYSTEM_FIELD_NAME column type