[Import Logs] Hide tab when application logger bundle is not installed or enabled (2.4 backport of #672) - #688
Merged
Conversation
…d or enabled (2.4 backport of #672) Backport of cfb57b3 to the 2.4 LTS line. The import-logs tab reads its data through the studio-backend-bundle application-logger endpoint, so it is only offered when PimcoreApplicationLoggerBundle is enabled and installed; otherwise the tab rendered but could never load data. Requires the isBundleActive helper from the studio-ui-bundle 2025.4 backport of pimcore/studio-ui-bundle#3980. The @pimcore/studio-ui-bundle npm dependency in assets/studio/package.json still needs to be bumped to the first 2025.4 canary that ships the helper once it is published - until then the studio frontend build of this branch cannot compile. Fixes pimcore/platform-version#145 (cherry picked from commit cfb57b3) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
On the 2025.4 LTS line the isBundleActive SDK helper only exists once pimcore/studio-ui-bundle#4074 ships, so the static import made this branch depend on an unpublished package. Resolve the helper from the federated app module at runtime instead: on an older studio-ui host the tab stays offered (previous behavior), on a host with the helper it is hidden when PimcoreApplicationLoggerBundle is inactive. Verified against the currently published @pimcore/studio-ui-bundle ^1.0.0 canary: tsc --noEmit clean, eslint clean, rsbuild production build succeeds. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ValeriaMaltseva
marked this pull request as ready for review
September 2, 2026 14:21
pimcore-deployments
marked this pull request as draft
September 2, 2026 14:22
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused backport correctly handles both newer and legacy Studio UI hosts without unresolved issues.
Pull request overview
Conditionally exposes Import Logs based on Application Logger bundle availability while preserving compatibility with older Studio UI hosts.
Changes:
- Adds runtime resolution with backward-compatible fallback.
- Conditionally includes the Import Logs tab.
File summaries
| File | Description |
|---|---|
utils/is-bundle-active.ts |
Resolves the optional SDK helper at runtime. |
components/data-importer-detail-view.tsx |
Hides Import Logs when the logger bundle is inactive. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ValeriaMaltseva
marked this pull request as ready for review
September 2, 2026 14:37
|
ValeriaMaltseva
deleted the
fix/145-backport-hide-import-logs-tab-2.4
branch
September 2, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #672 (cfb57b3) to the 2.4 LTS line
Fixes pimcore/platform-version#145 (together with pimcore/studio-ui-bundle#4074).
What
The Import Logs tab reads its data through the studio-backend-bundle application-logger endpoint — there is no data-importer-specific log controller. When
PimcoreApplicationLoggerBundleis not installed or enabled, the tab rendered but could never load data. It is now only offered when the bundle is active, matching #672 on 2026.x.LTS deviation from #672: runtime resolution instead of a hard dependency
On this line the
isBundleActiveSDK helper only exists once pimcore/studio-ui-bundle#4074 ships, so instead of the static import used on 2026.x, the helper is resolved from the federatedmodules/appat runtime (assets/studio/js/src/modules/data-importer/utils/is-bundle-active.ts):This keeps the branch buildable against the currently published
@pimcore/studio-ui-bundlenpm package and avoids coupling the two releases. Once a 2025.4 canary with the helper is published, the npm dependency can optionally be bumped and the static import restored to converge with 2026.x.Verified
tsc --noEmitclean, eslint clean,rsbuildproduction build succeeds — all against the currently published^1.0.0canary (i.e. without #4074).Notes
LogEntrypriorityTypeError) was already fixed for 2025.4 in [Bug]: Data Hub Import Log Error studio-backend-bundle#1841, released in v2025.4.4.🤖 Generated with Claude Code