Skip to content

Fix Is(Not)Abstract expression so that it does not ignore final classes #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
X-Coder264 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Fix Is(Not)Abstract expression so that it does not ignore final classes #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Expression/ForClasses/IsAbstract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti

public function appliesTo(ClassDescription $theClass): bool
{
return !($theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum() || $theClass->isFinal());
return !($theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum());
}

public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
Expand Down
2 changes: 1 addition & 1 deletion src/Expression/ForClasses/IsNotAbstract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function describe(ClassDescription $theClass, string $because): Descripti

public function appliesTo(ClassDescription $theClass): bool
{
return !($theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum() || $theClass->isFinal());
return !($theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum());
}

public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
Expand Down
6 changes: 3 additions & 3 deletions tests/Unit/Expressions/ForClasses/IsAbstractTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function test_enums_can_not_be_abstract_and_should_be_ignored(): void
self::assertFalse($isNotAbstract->appliesTo($classDescription));
}

public function test_final_classes_can_not_be_abstract_and_should_be_ignored(): void
public function test_final_classes_should_not_be_ignored(): void
{
$isAbstract = new IsAbstract();
$isNotAbstract = new IsNotAbstract();
Expand All @@ -106,7 +106,7 @@ public function test_final_classes_can_not_be_abstract_and_should_be_ignored():
->setFinal(true)
->build();

self::assertFalse($isAbstract->appliesTo($classDescription));
self::assertFalse($isNotAbstract->appliesTo($classDescription));
self::assertTrue($isAbstract->appliesTo($classDescription));
self::assertTrue($isNotAbstract->appliesTo($classDescription));
}
}
Loading