Improve opcache.max_accelerated_files validation#22412
Open
jack-worman wants to merge 1 commit into
Open
Conversation
jack-worman
changed the title
Member
|
This change is acceptable for master only. Can you first retarget the PR and afterwards rebase your branch onto master? |
jack-worman
force-pushed
the
Better-opcache.max_accelerated_files-validation
branch
from
b342d67 to
a276d2b
Compare
Author
Done. |
mvorisek
reviewed
Jun 23, 2026
| && size != 130987 | ||
| && size != 262237 | ||
| && size != 524521 | ||
| && size != 1048793 |
Contributor
There was a problem hiding this comment.
What is the reason to not allow number larger than 1048793?
Author
There was a problem hiding this comment.
I'm not sure; I only know that 1048793 has been the max since 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it improves clarity to be explicit about what values are allowed and to not implicitly coerce them.
At a minimum, MAX_ACCEL_FILES should be increased to be the real max value as this is a footgun.