Repository navigation
fix: validate checkout roots without losing pathname bytes - #18
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Refs #2. A focused initial-CLI correction, deliberately based on #7 at9666d997c864e4e74b7ca0ca8cbce849091353a7; HEAD054a66913bd8f3726ae285688c4bcd5a3ae5ab0f. This branch leaves #16's current review identity unchanged.
A real checkout whose root ends in space/tab/newline was rejected because trim(--show-toplevel) destroyed significant pathname bytes. Validate Git's boolean working-tree state and relative prefix instead of decoding the absolute root name. Explicitly reject metadata/bare directories as well as nested directories; --show-prefix alone is insufficient inside .git and was caught before publication.
Two red→green regressions prove complete/changed selection with root whitespace and check preserving source bytes, plus .git/bare rejection. Full local composer check passed21 tests/102 assertions and18 PHP syntax/ECS files; strict Composer/actionlint/whitespace pass. Fresh independent read-only review approved this exact HEAD, reran the suite and separately exercised common/linked worktree roots, whitespace-only nested directories and linked-worktree metadata. Offline cache install used no plugins/scripts.
Hosted checks and actual Codex AND CodeRabbit current-head reviews remain required before merge. No manual CodeRabbit request competes with #16's hourly queue. The initial PR must contain both the requested Container/POPO composition and this validated path correction, then receive renewed checks/reviews on its resulting HEAD before main. No merge/release is implied by local preflight or stale/skipped reviews.
No consumer, credentials, security settings or self-hostedCI changed. A patch fragment records the correction; only the approved0.x Changelog/Actions lifecycle may publish versions.