Skip to content

test: verify resolved preset and golden preservation contracts - #15

Open
coisa wants to merge 3 commits into
codex/extract-code-standardsfrom
codex/preset-regressions
Open

coisa wants to merge 3 commits into
codex/extract-code-standardsfrom
codex/preset-regressions

Conversation

@coisa

@coisa coisa commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Refs #5; depends on #7. This is a bounded regression increment, not completion of the full DevTools/CoiSA policy comparison. It deliberately targets codex/extract-code-standards, as a sibling of #13. Do not merge before the base layer; retargeting requires fresh identity and validation.

Records the actual compiled ECS13.3.8 preset:48 distinct fixers, explicit configuration, exact installed reference and non-risky classification. Tests verify each fixer's source belongs to that installation. Global Composer InstalledVersions changes its ECS identity after the bundled autoloader loads; the snapshot therefore reads installation-specific metadata.

Golden fixtures assert check preserves source, explicit fix matches reviewed bytes, and a second check/fix is stable. They preserve author/package/typed-param/void-return PHPDoc, visibility, mutable DateTime and header position/year. No consumer source is executed.

Preflight: base 9666d997c864e4e74b7ca0ca8cbce849091353a7 → head b5830371299aa6b1b19cf63c893cb317074c9951. Independent read-only reviewer /root/code_standards_review approved this exact head after reexecuting21 tests/208 assertions,19-file syntax/ECS check, Composer strict, actionlint, Changelog contribution and whitespace checks on PHP8.5.11. CI/reviews on the remote head remain separate gates.

Issue5 remains open for fully resolved legacy dependency graphs, headers/Finder comparisons and explicit opt-in decisions. No rules or production behavior change and no consumer migration. Merge still requires passing checks and real current-head Codex AND CodeRabbit without pending findings.

Refreshed through normal merges from the current initial branch; no published history rewritten. Fresh independent read-only review approved this exact updated head after reexecuting the stated tests. Remote reviews/checks must renew. The initial branch still awaits the requested composition in #16 and all resulting gates; no merge or release occurred.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 57fa5360-d959-4b60-bad0-4f0057ee2dac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T19:40:21.746708Z b583037 New commits
🔒 Security Review 🔄 Running since 2026-10-21T19:39:34.344368Z b583037 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coisa added 2 commits October 21, 2026 16:21
* codex/extract-code-standards:
  fix: load symlinked presets through ECS installation autoload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant