Allow a leaving channel to shut down gracefully - #6824
Open
SteffenDE wants to merge 1 commit into
Open
Conversation
Closes phoenixframework/phoenix_live_view#4411. In LiveView, we reuse the same channel for live navigation. When a client sends an event and then immediately leaves and rejoins, the rejoin could kill the channel while it was still handling the previous message. Since we know that its state is leaving, we give it up to 5s to finish pending work.
4 tasks
|
Interesting solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phoenixframework/phoenix_live_view#4411.
In LiveView, we reuse the same channel for live navigation. When a client sends an event and then immediately leaves and rejoins, the rejoin could kill the channel while it was still handling the previous message.
Since we know that its state is leaving, we give it up to 5s to finish pending work.