feat!: rewrite to use cucumber messages by daantimmer · Pull Request #273 · philips-software/amp-cucumber-cpp-runner

Daan Timmer (daantimmer) · 2025-12-18T23:32:17Z

This (internal) rewrite is to make amp-cucumber-cpp-runner cucumber-messages compatible. Both during runtime and during formatting.

This will enable amp-cucumber-cpp-runner to be compatible with other, standalone, formatters.

… compatibility kit

…r to catch errors

…ta, doc-strings, empty, examples-tables and minimal

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

…ation exists

github-actions · 2025-12-18T23:44:33Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	6		0	0	0.05s
✅ CPP	clang-format	229	0	0	0	1.9s
✅ DOCKERFILE	hadolint	1		0	0	0.04s
✅ JSON	jsonlint	8		0	0	0.37s
✅ JSON	prettier	8	6	0	0	0.63s
⚠️ MARKDOWN	markdownlint	6	3	14	0	1.19s
✅ MARKDOWN	markdown-table-formatter	6	3	0	0	0.33s
✅ REPOSITORY	git_diff	yes		no	no	0.02s
✅ REPOSITORY	grype	yes		no	no	33.33s
✅ REPOSITORY	ls-lint	yes		no	no	0.1s
✅ REPOSITORY	secretlint	yes		no	no	4.11s
✅ REPOSITORY	syft	yes		no	no	1.45s
✅ REPOSITORY	trivy	yes		no	no	9.72s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.23s
✅ REPOSITORY	trufflehog	yes		no	no	4.49s
⚠️ SPELL	lychee	83		1	0	3.93s
✅ YAML	prettier	10	0	0	0	0.77s
✅ YAML	v8r	10		0	0	7.24s
✅ YAML	yamllint	10		0	0	0.64s

Detailed Issues

⚠️ SPELL / lychee - 1 error

[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........155
✅ Successful.....154
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1

Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found

⚠️ MARKDOWN / markdownlint - 14 errors

CHANGELOG.md:26 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:38 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:47 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:53 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:61 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:65 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:70 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:79 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:90 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:98 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:102 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:127 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:134 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
README.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository

github-actions · 2025-12-18T23:51:59Z

Test Results

27 tests - 1 27 ✅ - 1 28s ⏱️ +24s
1 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 2e6a580. ± Comparison against base commit 44e129b.

This pull request removes 6 and adds 5 tests. Note that renamed tests count towards both.

test.bats ‑ Missing mandatory feature argument
test.bats ‑ Missing mandatory report argument
test.bats ‑ Second feature file does not overwrite success with an undefined status
test.bats ‑ Test the asterisk keyword - will fail
test.bats ‑ Test unused step reporting
test.bats ‑ Undefined tests

test.bats ‑ Second feature file does not overwrite success with an ■ status
test.bats ‑ Test nested steps
test.bats ‑ Test the asterisk keyword
test.bats ‑ Test usage formatter
test.bats ‑ ■ tests

♻️ This comment has been updated with latest results.

…discard]] attributes and restructuring functions

…eeRegexp, and test files

Copilot

Pull request overview

Copilot reviewed 291 out of 395 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ting logic

CMakePresets.json

Copilot

Pull request overview

Copilot reviewed 291 out of 398 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/engine/test_helper/CMakeLists.txt

cucumber_cpp/library/engine/test/CMakeLists.txt

cucumber_cpp/library/cucumber_expression/MatchRange.cpp

compatibility/TestCompatibility.cpp

… ExecuteImpl

…discard]] attributes and restructuring functions

Copilot

Pull request overview

Copilot reviewed 291 out of 404 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/engine/Step.cpp

cucumber_cpp/library/cucumber_expression/TreeRegexp.hpp

cucumber_cpp/library/Parameter.hpp

compatibility/BaseCompatibility.hpp

cucumber_cpp/library/cucumber_expression/MatchRange.hpp

cucumber_cpp/library/cucumber_expression/RegularExpression.hpp

cucumber_cpp/library/engine/ExecutionContext.hpp

- Introduced util::HookData and util::HookFactory to streamline hook management. - Updated HookRegistry to utilize new HookData structure for better encapsulation. - Refactored StepRegistry to use util::StepFactory for step creation. - Removed unnecessary includes and simplified code structure in HookRegistry and StepRegistry. - Added new Body class to handle execution and exception management for hooks and steps. - Implemented TransformHookData utility to convert HookData to cucumber messages format. - Enhanced error handling in Body execution with detailed reporting. - Updated TransformTable to correctly convert Table structures to pickle_table format. - Cleaned up SupportCodeLibrary by removing unused code and organizing includes.

Copilot

Pull request overview

Copilot reviewed 291 out of 431 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/formatter/CMakeLists.txt

cucumber_cpp/library/CMakeLists.txt

cucumber_cpp/library/cucumber_expression/RegularExpression.hpp

cucumber_cpp/library/BodyMacro.cpp

cucumber_cpp/library/assemble/test/TestDummy.cpp

cucumber_cpp/library/api/test/TestDummy.cpp

Copilot

Pull request overview

Copilot reviewed 291 out of 434 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/cucumber_expression/RegularExpression.cpp

cucumber_cpp/library/cucumber_expression/Argument.hpp

cucumber_cpp/library/cucumber_expression/Argument.cpp

cucumber_cpp/library/api/Formatters.cpp

cucumber_cpp/library/engine/CMakeLists.txt

Copilot

Pull request overview

Copilot reviewed 291 out of 434 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cucumber_cpp/library/formatter/CMakeLists.txt

cucumber_cpp/library/Parameter.hpp

CMakePresets.json

CMakeLists.txt

… hooks

sonarqubecloud · 2026-03-04T14:49:16Z

Quality Gate passed

Issues
76 New issues
2 Accepted issues

Measures
0 Security Hotspots
80.9% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Daan Timmer (daantimmer) added 22 commits December 8, 2025 12:44

feat!: rewrite to use cucumber messages

1457b95

enable ccache

e8e9362

disable the build of shared libs

792332e

disable position independent code generation for jbeder/yaml-cpp

e8c96aa

add additional launch tags

48d99c6

add first version (empty, minimal and data-tables are enabled) of the…

1ae9468

… compatibility kit

refactored a lot of code

10137be

removed unused files

7ac6e9c

update devcontainers for CI

77b4762

removed agauniyal/rang from dependencies

50a2bce

cleanup Application

4054607

sanitize and dump actual and expected json

45a4380

set option variables for dependencies as cache variables

958e05c

fix grouping for string parameter

6eb2da0

use ScopedFakeTestPartResultReporter instead of EmptyTestEventListene…

ece0b62

…r to catch errors

Enable the following compatibility tests: ambiguous, backgrounds, cda…

6f1f4c8

…ta, doc-strings, empty, examples-tables and minimal

add examples-tables-attachment compatibility test

07a77d7

add attachments compatibility test

028dcc5

enabled examples-tables-undefined and global-hooks compatibility test

640986f

Added global-hooks-afterall-error, global-hooks-attachments, global-h…

cbb2f0c

…ooks-beforeall-error, hooks, hooks-attachment and hooks-conditional compatibility tests

add all compatibility checks by default regardless if a cpp implement…

dfe7157

…ation exists

add hooks-named, hooks-skipped and hooks-undefined compatibility tests

de2aaeb

Daan Timmer (daantimmer) mentioned this pull request Dec 18, 2025

feat: ndjson reporting #240

Closed

15 tasks

Daan Timmer (daantimmer) added 2 commits December 18, 2025 23:40

add multiple-features and multiple-features-reverses compatibility tests

d1a3e52

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

cad1bcf

Daan Timmer (daantimmer) added 3 commits December 19, 2025 09:46

fix clang-msvc build

83c6e5a

fix clang-msvc build

13484a5

fix MSVC build

c7ee029

Daan Timmer (daantimmer) added 3 commits February 18, 2026 09:50

refactor: enhance code readability and maintainability by adding [[no…

dfef9ca

…discard]] attributes and restructuring functions

add unit tests for cucumber_expression RegularExpressions

8255af5

refactor: remove unused includes from Argument, ParameterRegistry, Tr…

25a7982

…eeRegexp, and test files

Copilot AI review requested due to automatic review settings February 19, 2026 16:00

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Daan Timmer (daantimmer) and others added 2 commits February 25, 2026 23:42

refactor: change SortMappedByRegex return type to bool and update sor…

4c33bf8

…ting logic

optimizing compilation speed

c22027f

Copilot AI review requested due to automatic review settings March 2, 2026 13:16

github-actions bot reviewed Mar 2, 2026

View reviewed changes

CMakePresets.json Show resolved Hide resolved

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits March 2, 2026 13:31

refactor: include <type_traits> and update argument transformation in…

25e86a9

… ExecuteImpl

refactor: enhance code readability and maintainability by adding [[no…

bc85483

…discard]] attributes and restructuring functions

Copilot AI review requested due to automatic review settings March 2, 2026 14:38

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Daan Timmer (daantimmer) added 3 commits March 3, 2026 10:47

Removed most includes leading up to a json include

4f92c8d

fixed copilot comments

c34090e

Copilot AI review requested due to automatic review settings March 3, 2026 13:31

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits March 3, 2026 14:15

Reduce duplication

95b6d1f

refactor: remove BodyMacro implementation and update CMakeLists

6b46a7d

Copilot AI review requested due to automatic review settings March 3, 2026 15:28

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Daan Timmer (daantimmer) added 2 commits March 3, 2026 16:56

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

a5fd623

Merge branch 'main' into feature/rewrite-to-use-cucumber-messages

3f75d13

Copilot AI review requested due to automatic review settings March 4, 2026 10:08

Copilot AI reviewed Mar 4, 2026

View reviewed changes

cucumber_cpp/library/formatter/CMakeLists.txt Show resolved Hide resolved

cucumber_cpp/library/Parameter.hpp Show resolved Hide resolved

CMakePresets.json Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

André Jordan (andjordan) approved these changes Mar 4, 2026

View reviewed changes

refactor: update Hook and TestCaseRunner to include error handling in…

2e6a580

… hooks

Conversation

Daan Timmer (daantimmer) commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅⚠️MegaLinter analysis: Success with warnings

Detailed Issues

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 4, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Daan Timmer (daantimmer) commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading