Conversation
F8 is bound to the Live Preview edit toggle (_handlePreviewBtnClick),
which calls LiveDevelopment.setMode(LIVE_EDIT_MODE) and shows the
UPSELL_TYPE_LIVE_EDIT dialog for free users. The F-key forwarding
tests dispatched F8 into the mdviewer iframe, which was then forwarded
to Phoenix's document-level F8 handler — stacking 2 upsell dialogs
in the test runner.
Swap to F9 (unbound) — the test only needs to verify that F-keys
are forwarded from the iframe, it doesn't need F8 specifically.
Also rename the outer describe to "livepreview:Markdown Editor 1" to
match sibling suites ("Edit Mode", "Edit More", "Table Editing").
New string used by the device-size cycle button in phoenix-pro when no other cycle target fits the available width in normal preview mode.
The fit-to-panel button only appeared in design mode when a responsive viewport was active. Its role is now folded into the device size cycle button in phoenix-pro, which treats "fit" as a 4th cycle state when in design mode. Drops the dedicated button, its CSS, and the unused DEVICE_SIZE_FIT_TO_PANEL string.
Used by the "Fit to screen" item in the live preview device size dropdown in phoenix-pro (visible only in design mode).
At non-integer DPR (e.g. 110% browser zoom), subpixel rounding could leave a ~1px strip of body bg visible between #centralControlBar and its neighbors — sidebar on the left, editor on the right. Add a solid zero-blur box-shadow on both sides so CCB-colored pixels paint into those gaps without changing any geometry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.