Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!iframeWindow) { | ||
| return; | ||
| } | ||
| iframeWindow.postMessage({ |
Add a gold crown icon after the "Edit" text to indicate it's a Pro feature, so free users know before clicking. Pro status is sent from Phoenix to the md viewer iframe via MDVIEWR_SET_PRO_STATUS message on iframe ready and on entitlement changes.
…sion - Save scroll position before hiding md iframe (panel close / HTML switch) so it can be restored on reopen. Wrapped in try-catch to handle sandboxed cross-origin iframe access that was causing a SecurityError and breaking the md-to-html preview switch entirely. - Flush (not cancel) pending debounced content-change in handleSwitchFile and handleSetContent so outgoing file edits are preserved in cache, preventing data loss when users switch files within the 50ms debounce window. - Tag mdviewrContentChanged messages with filePath so MarkdownSync can verify the change matches the active document, preventing stale edits from a previous file from modifying the wrong CM document. - Guard MarkdownSync._onIframeContentChanged against stale content changes arriving after document close (null CM check + filePath mismatch check). - Guard doc-cache.saveActiveScrollPos against overwriting saved non-zero scroll with 0 after browser resets scrollTop on hide/show. - Fix _waitForMdPreviewReady in all 4 md test files: increase timeout from default 2s to 5s, re-read editor content each poll iteration so comparison adapts to async content sync that may modify the document.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a gold crown icon after the "Edit" text to indicate it's a Pro feature, so free users know before clicking. Pro status is sent from Phoenix to the md viewer iframe via MDVIEWR_SET_PRO_STATUS message on iframe ready and on entitlement changes.