chore(deps): consolidated dependency bumps (setuptools, fast-uri, tar, shell-quote, svgo)#10199
Merged
asheshv merged 1 commit intoJul 24, 2026
Conversation
…, shell-quote, svgo) Supersedes 7 open Dependabot PRs by applying the safe ones and properly fixing the one with a broken lockfile, in one CI cycle: - setuptools ==82.* -> ==83.* (pgadmin-org#10144, pgadmin-org#10145 - duplicate PRs, same patch). Only touches the `python_version > '3.9'` line; the `<82; python_version <= '3.9'` gate for Python 3.9 is untouched, so this doesn't affect Python 3.9 support. - fast-uri 3.1.2 -> 3.1.4 in both /web and /runtime (pgadmin-org#10183, pgadmin-org#10195) - fixes two real CVEs (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6). - tar 7.5.16 -> 7.5.21 (pgadmin-org#10182) - patch series, decompression-bomb and unbounded-recursion hardening only. - shell-quote 1.8.4 -> 1.10.0 (pgadmin-org#10185) - additive opt-in option + parser fixes, no breaking changes. - svgo 3.3.3 -> 4.0.2 (pgadmin-org#10184) - Dependabot's own PR left yarn.lock internally inconsistent (dropped the workspace-level `svgo` entry while merging version-range blocks), so `yarn install --immutable` failed in CI with "the lockfile would have been modified by this install". Regenerated properly via `yarn up`/`yarn dedupe` here. The direct `svgo`/`svgo-loader` deps are not actually wired into any webpack rule (verified via grep) - the real SVG pipeline is `@svgr/webpack` -> `@svgr/plugin-svgo` -> svgo 3.3.3, which this bump does not touch - so the major version jump has no build impact. `yarn.lock` now correctly keeps that separate 3.3.3 resolution alongside the deduped 4.0.2 one. Not included (structurally blocked, tracked separately): - paramiko 3.5.1 -> 5.0.0 (pgadmin-org#9927): paramiko 5 removes DSSKey entirely; sshtunnel 0.4.0 (dormant since 2021) still references paramiko.DSSKey, so `import sshtunnel` would crash immediately. - pywinpty 2.0.* -> 3.0.* (pgadmin-org#10082, pgadmin-org#10084): the existing pin cites andfoy/pywinpty#545, confirmed still open ("process read and write not working as expected in 3.x"). Verified: `yarn install --immutable` clean in both /web and /runtime, `yarn run linter` clean, full `yarn run bundle:dev` compiles successfully.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
WalkthroughDependency constraints are updated for Python and web tooling: ChangesDependency updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes 7 open Dependabot PRs by applying the safe ones and properly fixing the one with a broken lockfile, in one CI cycle, following the precedent of #10023.
Included
==82.*→==83.*(Python dependency: Update setuptools requirement from ==82.* to ==83.* #10144, Python dependency: Update setuptools requirement from ==82.* to ==83.* in /web/regression #10145 — duplicate PRs, identical patch). Only touches thepython_version > '3.9'line; thesetuptools<82; python_version <= '3.9'gate is untouched, so Python 3.9 support is unaffected.3.1.2→3.1.4in both/weband/runtime(Javascript dependency: Bump fast-uri from 3.1.2 to 3.1.4 in /web #10183, Javascript dependency: Bump fast-uri from 3.1.2 to 3.1.4 in /runtime #10195) — fixes two real CVEs (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6).7.5.16→7.5.21(Javascript dependency: Bump tar from 7.5.16 to 7.5.21 in /web #10182) — patch series, decompression-bomb guard + unbounded-recursion fix only, no breaking changes. Also bumped the project's own forcedresolutions["tar@npm:^7.5.4"]pin to match.1.8.4→1.10.0(Javascript dependency: Bump shell-quote from 1.8.4 to 1.10.0 in /web #10185) — additive opt-in parser option + fixes, no breaking changes.3.3.3→4.0.2(Javascript dependency: Bump svgo from 3.3.3 to 4.0.2 in /web #10184) — see below.Why #10184 needed manual work
Dependabot's own PR left
yarn.lockinternally inconsistent: it merged thesvgo@npm:^4.0.1/svgo@npm:^4.0.2resolution blocks but dropped the workspace-levelsvgodependency entry that mirrorspackage.json. Result:yarn install --immutablefails in CI with "the lockfile would have been modified by this install."Regenerated properly here via
yarn up svgo@4.0.2+yarn dedupe svgo. Also verified the actual risk of the 3→4 major bump: the directsvgo/svgo-loaderdeps are not wired into any webpack rule (greppedwebpack.config.js— zero references). The real SVG import pipeline is@svgr/webpack→ its own bundled@svgr/plugin-svgo→ svgo3.3.3, which this bump doesn't touch at all (confirmed viayarn why svgo— that resolution stays untouched, correctly kept separate from the deduped 4.0.2). So this bump has no effect on the actual build output.Not included (structurally blocked, tracked separately)
3.5.1→5.0.0(Python dependency: Bump paramiko from 3.5.1 to 5.0.0 #9927): paramiko 5.0.0 removesDSSKeyentirely (verified by inspecting the actual wheel —paramiko/__init__.pyno longer imports it).sshtunnel0.4.0(dormant since 2021) still has a hard module-level reference toparamiko.DSSKey, soimport sshtunnelwould crash immediately — matches that PR's own CI failing in 17s–3min across every job.2.0.*→3.0.*(Python dependency: Update pywinpty requirement from ==2.0.* to ==3.0.* #10082, Python dependency: Update pywinpty requirement from ==2.0.* to ==3.0.* in /web/regression #10084): the existing pin inrequirements.txtcites andfoy/pywinpty#545, confirmed still open ("process read and write not working as expected in 3.x"). Bumping walks straight into the bug the pin exists to avoid.Testing
yarn install --immutableclean in both/weband/runtime(the exact check CI runs).yarn run linterclean.yarn run bundle:dev—webpack 5.108.4 compiled successfully.pycodestyle --config=.pycodestyle requirements.txt-relevant check: N/A (plain requirements pin, no Python code changed).Once merged, #10144, #10145, #10182, #10183, #10184, #10185, #10195 can all be closed as superseded.
Summary by CodeRabbit