Fix/sync mkdocs major section spock v6 - #129
Conversation
Products split into per-major sections (e.g. 'Spock v5') share one repo URL, so a new major (v6.0.0-beta.1) was sorted into the v5 block. Scan the major named in each section header and, for products in an explicit MAJOR_SPLIT_PRODUCTS allowlist (Spock for now), report a version whose major has no matching section as NEW SECTION for manual placement rather than auto-inserting it into the wrong major. Add the allowlist so future major-split products are onboarded with a one-line change. Also add the Spock v6 nav section and landing tile.
WalkthroughThe mkdocs sync workflow adds a ChangesSync workflow major-split detection
Estimated code review effort: 3 (Moderate) | ~25 minutes mkdocs.yml versioned docset additions
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@mkdocs.yml`:
- Around line 625-628: The Spock v6 mkdocs import is pointing at a non-existent
Git ref, so the `!import` for the `Spock v6` entry will fail. Update the
`v6.0.0-beta` import in `mkdocs.yml` to use a real branch or tag that exists in
`pgEdge/spock`, keeping the `Spock v6` navigation entry and `!import` syntax
intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3f0f9b0f-d41b-4ff3-a0cb-37e43594bae0
📒 Files selected for processing (2)
.github/workflows/sync-mkdocs.ymlmkdocs.yml
Deploying pgedge-docs with
|
| Latest commit: |
fc0825b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8fc3a27a.pgedge-docs.pages.dev |
| Branch Preview URL: | https://fix-sync-mkdocs-major-sectio.pgedge-docs.pages.dev |
Fixes workflow to detect multiple major versions of Spock
Adds new products Spock v6 and Supautils
Summary by CodeRabbit
New Features
Bug Fixes