Add favicon updates and dark mode favicon swap - #41
Merged
Conversation
Entire-Checkpoint: 5491ad1df48b
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Entire-Checkpoint: 1599c3fe9104
Owner
Author
|
the favicon swap most likely won't work due to caching, but at least we updated:
still worth doing. Make sure to text on devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
favicon-dark.png)How it works
The
FavIconscomponent now uses React state to track the current theme (data-themeattribute) and updates faviconhrefattributes accordingly when the theme changes.Test plan