feat: desktop max-width constraints for cards and headers - #39
Merged
Conversation
- Home hero card capped at 46rem, centered - Home heading cards capped at 33rem, content cards at 44rem - Increased card/pair gap for more vertical breathing room - Contact headerPill and formCard switched from fixed px to responsive max-widths (37%/30% and 50%/40% at desktop/4K breakpoints) Entire-Checkpoint: 55e1ea4ddf7d
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
46rem, centered with margin auto33rem, content cards at44rem(matching Penpot Intro frame specs)2.5rem→4rem) and pair gap (1.5rem→2.5rem) for more vertical breathing roomheaderPillandformCardswitched from fixed px widths to responsive max-widths:headerPill: 90% mobile → 37% desktop → 30% 4KformCard: 90% mobile → 50% desktop → 40% 4KTest plan
/on desktop — hero card, heading cards, and content cards should be constrained and centered/contacton desktop — form card wider than header pill/contacton a 4K display — both cards narrower than desktop